[MPlayer-dev-eng] last printf in libaf

[Reynaldo H. Verdejo Pinochet]

On Mon, Mar 13, 2006 at 11:15:23PM -0800, Corey Hickey wrote:
> Reynaldo H. Verdejo Pinochet wrote:
> > Hope is ok to commit, is the last one on libaf
> 
> [cut]
> 
> > +// af_format.c
> > +
> > +#define MSGTR_AF_FORMAT_UnknownSpecial "Unknown special\n"
> 
> My first thought was, "what does that mean?" I took a look at the code,
> and thought saying "unknown format" or maybe "unknown special format"
> would be better.
> 
> Then, I saw that it's in af_fmt2str(), which looks like it converts a
> numeric format into a string for human consumption. Wouldn't it be
> better to use snprintf() to put that message into the string so it gets
> printed in the proper context?
> 
> I would prefer the attached patch.

Hi Corey, I didnt get to read this message before commiting :/ there
where problems with the ml. I agree, at least the message needs to be
rethinkered/rewrited, could you please take care of the modification?

Regards

  Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060314/73e4e9c9/attachment.pgp>