[MPlayer-dev-eng] Re: [PATCH]H264 over rtsp

[Ross Finlayson]

My response to this is exactly the same as it was back on May 7th, 
when I first looked at this patch:

>Most of this looks OK, *except* for that hideous code that you've 
>added to the "getBuffer()" routine in "demux_rtp.cpp".  I'm not sure 
>what that code is supposed to be doing, but it looks like it's 
>trying to do some filtering on the incoming data that should really 
>be done (if at all) by the H.264 decoding library instead.  In any 
>case, the VLC code doesn't do anything like this, and neither should MPlayer.

Note especially the last sentence.


	Ross Finlayson
	Live Networks, Inc. (LIVE555.COM)
	<http://www.live555.com/>