[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Sunday 18 June 2006 17:38, Rich Felker wrote:
> Why not just bypass fontconfig? I don't even have fontconfig and I'm
> quite happy with the way MPlayer works.

How exactly ? I've got font family, weight and slant values and need to get a 
font with most close characteristics. Ok, embedded subs often go with 
embedded fonts, I can open them all with FreeType and read their parameters. 
But what should I do if the script wants some standard font like Helvetica ? 
Reimplement fontconfig ?

> > > > Index: mencoder.c
> > > > ===================================================================
> > > > --- mencoder.c	(.../branches/upstream)	(revision 503)
> > > > +++ mencoder.c	(.../trunk)	(revision 503)
> > > > @@ -54,6 +54,7 @@
> > > >  #include "libmpdemux/stheader.h"
> > > >  #include "libmpdemux/mp3_hdr.h"
> > > >  #include "libmpdemux/muxer.h"
> > > > +#include "libmpdemux/matroska.h"
> > >
> > > Why is this needed? Can it be avoided? (if this is in mplayer.c as
> > > well, same question there *g*)
> >
> > For mkv_sh_sub_t definition.
>
> Should be some way to fix this to be demuxer-independent.

It can be moved to demux_stream_t. Probably the same should be done with 
VobSub.