[MPlayer-dev-eng] [patch] libvorbis support matrsoka style headers

[Nico Sabbi]

Balatoni Denes wrote:

>Hi!
>
>szombat 06 május 2006 17.55-kor Nico Sabbi ezeket a bolcs gondolatokat 
>fogalmazta meg:
>  
>
>>has it changed?
>>I remember that I changed this file to make it accept only the layout of
>>extradata
>>used at the time by matroska (and I had to change all other demuxers
>>accordingly)
>>    
>>
>
>It didn't change, but libvorbis doesn't accept the two different kinds of 
>header format that ffvorbis does. I thought the new one was the one used by 
>matroska, but anyhow it is used by
>http://www.mplayerhq.hu/MPlayer/samples/MPEG-4/vorbis-in-mp4/mi2_vorbis51.mp4
>
>bye
>Denes
>
>  
>

attached is the patch I'm going to commit if no one is against it.
This was for me the chance to discover that there a lot of gross errors
both in demux_mov.c and in parse_mp4.[ch], the main of which are:
- esds atoms are not strictly related to aac (demux_mov.c makes 
everywhere this assumption),
because they simply contain information+extradata for whichever ES 
stream they refer to
- the length of mp4 descriptors is not limited to 1 byte: the length is 
coded as uvlc and may
span more bytes (for security reasons I limited decoderConfigLen to 16 
bits, because bigger
lengths are unlikely to ever happen).

Patch works both with -ac vorbis and with -av ffvorbis.

    Nico


-------------- next part --------------
A non-text attachment was scrubbed...
Name: movorbis.diff
Type: text/x-patch
Size: 5027 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060609/b0c9d6c4/attachment.bin>