[MPlayer-dev-eng] [PATCH] Audio support for AVISynth

[Reimar Döffinger]

Hello,
On Sun, Jul 23, 2006 at 02:53:26AM +0200, Gianluigi Tiesi wrote:
> Revised, "cosmetized" and cleaned patch:
> http://oss.netfarm.it/mplayer/patches/xx_demux_avs_audio.diff

> -    if (!AVS->x) { mp_msg(MSGT_DEMUX,MSGL_V,"AVS: failed to load "Q(x)"()\n"); return 0; }
> +    if (!AVS->x) { mp_msg(MSGT_DEMUX, MSGL_V,"AVS: failed to load "Q(x)"()\n"); return 0; }

can't see a non-cosmetic change here :-)
Same here:
> -        mp_msg(MSGT_DEMUX ,MSGL_V, "AVS: failed to load avisynth.dll\n");
> +        mp_msg(MSGT_DEMUX, MSGL_V, "AVS: failed to load avisynth.dll\n");

here:

> -    }
> -    
> +    }   

And many, many more places (including some conversions of // to /*
comments).

Also I think this:
> +    sh_audio_t *sh_audio = d_audio->sh;

Might crash in video-only case, though I didn't check properly.

This seems like an unrelated change:
> -        d_video->pts=AVS->frameno / sh_video->fps; // OSD
> +        dp->pts = (float) AVS->frameno / sh_video->fps;

I'm against commiting it in this form.

Greetings,
Reimar Döffinger