[MPlayer-dev-eng] [PATCH] vf_bmovl: respect destination stride

Jason Tackaberry tack at urandom.ca
Thu Jul 13 17:58:22 CEST 2006


Hi Diego,

On Thu, 2006-07-13 at 12:58 +0200, Diego Biurrun wrote:
> Time to submit that thing for eventual inclusion?

I will submit it again next week.

There was quite a bit of scrutiny originally when I submitted it last
year, because it touches some core parts in mplayer.c due to
requirements that the overlay be updatable while paused and as well the
update framerate be independent of the video framerate.  (I have since
disabled the latter due to juddering issues as a result of changes that
got introduced by some changes in mplayer late last year and I haven't
been able to narrow it down.  See my post here:
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-April/042411.html )

Reimar helped me split out some of that code by creating a
VF_PERIODIC_UPDATE vf control.  I will submit this as a separate patch
first.

However recently libinput stopped being linked with mencoder, and
vf_overlay uses mp_input_get_cmd() and mp_input_add_cmd_filter() so
there were linking problems.  I added a couple stub functions to
mencoder.c to fix this (along with a couple other stubs from libinput
that were also added), but I have a feeling this will also be met with
some resistance.  Consequently I have been procrastinating the whole
thing. :)

If there is general interest in vf_overlay outside of the Freevo project
though then I'd be more motivated to try the process again.

Cheers,
Jason.




More information about the MPlayer-dev-eng mailing list