[MPlayer-dev-eng] ppc runtime-cpu-detection fails with gcc 3.3

[Guillaume POIRIER]

Hi,

On 2/23/06, Alan Curry <pacman at theworld.com> wrote:
> Ivan Kalvachev writes the following:
> >
> >2006/2/23, Alan Curry <pacman at theworld.com>:
> >> It looks to me like we should blacklist the combination of ppc,
> >> runtime-cpu-detect, and gcc 3.3 in configure. Objections? Alternatives?
> >> Comments?
> >
> >MPlayer have old-day policy of _not_ workarounding gcc bugs (read gcc
> >2.96 flames;)
> >It would be much simpler to just blacklist the 3.3.x that produce this
> >bug and require the newer (fixed) version.
>
> OK, here's a specific patch for inspection:

[..]

> +    if test "$_runtime_cpudetection" = yes -a \
> +           "$cc_vendor" = "gnu" -a "$_cc_major" = 3 -a "$_cc_minor" = 3; then

Seem good to me. You do restrict the black list to FSF's GCC3.3. :)

If ever it turns out that Apple's is bad too, then we can just remove
 "$cc_vendor" = "gnu" -a

Guillaume
--
Reinventing the wheel certainly is annoying, but as long as all other
wheels are square...

Reimar Döffinger