[MPlayer-dev-eng] Re: [PATCH] More complete ASF MIME detection, closing bug# 248

[Guillaume POIRIER]

Hi,

On 11/6/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hi,
> On Sun, Nov 06, 2005 at 03:09:25PM +0100, Guillaume POIRIER wrote:
> > On 11/6/05, Zuxy <zuxy.meng at gmail.com> wrote:
> > > 2005/11/2, Zuxy <zuxy.meng at gmail.com>:
> > > > Also consistent with asf mime types in asf_streaming.c.
> > >
> > > No comments?
> >
> > Good patch. I'll gladly apply it tonite unless someone objects.
> > Reimar, you're listed in bugzilla as one of the few who had a look a
> > the bug. Could you have a look at the patch too?
>
> Well, it might be better to fix the auto-detection of the asf
> demuxer - especially since I really hate that mime-type stuff.
> And I agree that at least octet-stream should not be "hardwired" to the
> asf demuxer.

What's up with this patch (re-attached)? I Roberto's and Reimar's
comments made it look like it was okay, though more work should be
done to improve the core code, but until then...

I'm tempted to apply this patch, but unwilling to drink the cola if if
breaks something...

Would it be okay to apply it (if it still applies cleanly) to get some
testing, and remove it if ever it messes things up?

Guillaume
--
Just because code is syntactically "valid" GNU C doesn't mean gcc can
always compile it.
  Steven Bosscher - 2005-01-01
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11203#c14
-------------- next part --------------
A non-text attachment was scrubbed...
Name: network.c.diff
Type: text/x-patch
Size: 531 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060220/b80917ca/attachment.bin>