[MPlayer-dev-eng] [PATCH] altivec_yuv2packedX vs. dstFormat

Diego Biurrun diego at biurrun.de
Thu Feb 16 11:19:25 CET 2006


On Wed, Feb 15, 2006 at 11:26:25PM +0100, Michael Niedermayer wrote:
> 
> On Wed, Feb 15, 2006 at 04:37:38PM -0500, Alan Curry wrote:
> > Since the last set of patches, altivec_yuv2packedX now supports 6 output
> > formats rather than just 1, but it still doesn't support as many formats as
> > yuv2packedXinC. This patch avoids calling altivec_yuv2packedX with a format
> > that it can't produce, falling back on yuv2packedXinC. To see the difference,
> > use for example -vf scale=199:-2 -bpp 16 or
> > -vf scale=199:-2,format=bgr16,scale on an altivec-enabled mplayer.
> > 
> > The patch is in 2 parts to ease readability. The first part is the
> > substantive change. The second part adjusts the indentation so that it makes
> > sense again.
> 
> patch looks ok ...

Alan, you have around 5-10 patches pending right now, I lost count.
About half of them (I lost count here as well) were approved by Michael
and would thus be OK to commit after some testing.

I'm the only (active) reviewer with a PPC and I won't have time to test
and commit your patches in the next few weeks, so they'll only continue
to pile up.

You've done everything right so far, we trust your judgement that you
will continue doing so in the future.  Send me your username and
password in private and become a developer already :)

Diego




More information about the MPlayer-dev-eng mailing list