[MPlayer-dev-eng] [PATCH] ve_lavc cosmetics

[Michael Niedermayer]

Hi

On Tue, Feb 14, 2006 at 01:35:49AM +0100, Diego Biurrun wrote:
> On Mon, Feb 13, 2006 at 07:31:29PM -0500, Rich Felker wrote:
> > On Tue, Feb 14, 2006 at 01:03:43AM +0100, Diego Biurrun wrote:
> > > On Mon, Feb 13, 2006 at 12:39:21AM +0100, Michael Niedermayer wrote:
> > > > 
> > > > On Sun, Feb 12, 2006 at 03:51:51PM -0500, Rich Felker wrote:
> > > > [...]
> > > > 
> > > > > The idea that whitespace should conform to a single 'coding style'
> > > > > rule is IMO very misguided. The purpose of whitespace is to break the
> > > > > logical units (logical in terms of how humans think about it, not how
> > > > > the machine things) up in a way that makes them easier to read. This
> > > > > depends on the semantics of the code, not the syntax.
> > > > 
> > > > yes, i fully agree
> > > > here are a few more examples which would be literally obfuscated if
> > > > they where are automatically reformated
> > > 
> > > I don't think I was expressing myself very clearly..
> > > 
> > > I was not proposing to add spaces regardless of context, just to be
> > > consistent when adding spaces around operators like
> > > 
> > > var1=value;
> > > var2 = value;
> > 
> > And to be clear, I was explicitly saying that consistency in this area
> > is NOT desirable.
> 
> I don't think we actually disagree, but I'm too tired to continue to
> argue and I'm apparently not making myself understood...

id say we all partly agree and partly disagree, and that iam partly tired ...
so the only partly logic solution would be to partly apply the patch
= (without the spaces cosmetics around = )

everyone partly happy now? ;)

[...]

-- 
Michael