[MPlayer-dev-eng] Re: [BUG] various weirdness in vf_expand when expanded width > frame width

[Jason Tackaberry]

On Sun, 2006-12-31 at 15:40 +0100, Tomas Janousek wrote:
> The vf_expand lacks the code to clear the left/right sides, having a 
> //TODO instead. It does that for top/bottom so it should certainly be 
> there. I posted a patch addressing this a while ago, please look into 
> the archives for a thread called "[PATCH] vf_expand - clear left and 
> right side of the image if needed" and check whether it solves the issue 
> for you.

I did indeed see the TODO in the code, but given that when vf_expand
expands width-wise if the expand osd parameter is set I don't even see
the OSD at all, I didn't bother looking further there.

Unlike when the height gets expanded, when the width is expanded the
default OSD seems to render in the bands.  I suppose it should be this
way.

My primary issue was that the left/right bands were gray, but later
discovered that was mainly a property of the vo, and all VOs behaved
differently.  My patch yesterday addresses this in vo_xv (but it just
occurred to me that I did it the wrong way).

I'll try fixing vf_expand's osd in this case (if it's just a matter of
wrong offsets it should be easy enough) and retry your patch.  If it
works I'll push a bit to get it merged. :)

Thanks,
Jason.