[MPlayer-dev-eng] [PATCH] configure: enhancement for runtime cpu detection and --target support under x86

[Zuxy Meng]

Hi,

2006/12/12, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
>
> Build system is not my area, but some random comments:
>
> On Mon, Dec 04, 2006 at 10:26:53PM +0800, Zuxy Meng wrote:
> > +if [ "$_runtime_cpudetection" = yes ] ; then
>
> This applies to many, many places in the patch. I think for
> compatibility reasons you're supposed to use the 'test' command instead
> of []
>
> > +  if ! ( x86 || x86_64 || ppc ) ; then
>
> and "not" instead of !, there are shells that do not support '!'
>
> > -elif x86 || x86_64; then
> > +elif x86 || x86_64 && [ "$_runtime_cpudetection" = no -a -z "$_target" ] ; then
>
> And do not use -a, use two checks and combine them with && (many more
> cases of that)


Hmm...[], ! and -a/-o are used elsewhere in the configure. Forgive me
I really didn't have any idea which alternative provides better
compatibility.

> >       ;;
> > -    6) iproc=686
> > +      6) iproc=686
>
> cosmetics (also in some more places)

No. It's intended to accommodate a new surrounding 'case..esac' pair.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6