[MPlayer-dev-eng] [PATCH] Fix V4L2 buffer operations and tuner handling

Benjamin Zores ben at geexbox.org
Wed Dec 6 10:19:37 CET 2006


> Hi everybody,
>
> this patch fixes problems with video acquisition through the V4L2 API. Two
> separate issues are addressed, which prevented MPlayer from working with
> UVC
> (USB Video Class) devices.
>
> - Many V4L2 devices (mostly webcams) have no tuner. For those devices the
> concept of norm just doesn't apply. VIDIOC_G_STD should not be called for
> those tuner-less devices.
>
> - The buffer management (using VIDIOC_QBUF, VIDIOC_DQBUF and
> VIDIOC_REQBUFS)
> code doesn't set the buffer memory type to V4L2_MEMORY_MMAP. While many
> drivers fails to check the parameter, it is nonetheless mandatory to set
> it
> to the correct value.

The patch looks good to me but please resend without the cosmetic changes.
All of the patch isn't needed.

Ben




More information about the MPlayer-dev-eng mailing list