[MPlayer-dev-eng] Re: [PATCH]Unicode support for ASF demuxer

[Reimar Döffinger]

Hello,
On Tue, Nov 28, 2006 at 04:23:07PM +0800, Zuxy Meng wrote:
[...]
forgot something:

> +        if((len = contenth->title_size) != 0) {
> +          wstring = (uint16_t*)&hdr[pos];
> +          pos += len;

Here you use spaces.

>            if (pos > hdr_len) goto len_err_out;
> -          if( mp_msg_test(MSGT_HEADER,MSGL_V) )
> -            print_asf_string(" Title: ", string, contenth->title_size);
> -	  else
> -	    pack_asf_string(string, contenth->title_size);
> -	  demux_info_add(demuxer, "name", string);
> +	  if (string = get_ucs2str(wstring, len)) {
> +	    mp_msg(MSGT_HEADER,MSGL_V," Title: %s\n", string);
> +	    demux_info_add(demuxer, "name", string);
> +	    free(string);
> +	  }

And here tabs.
Please try to make it consistent. I prefer spaces, but that is up to
you.
Also some compilers nowadays warn about
if (string = get_ucs2str(wstring, len))
so maybe add an extra ():
if ((string = get_ucs2str(wstring, len)))
to silence them

Greetings,
Reimar Döffinger