[MPlayer-dev-eng] [PATCH] Convert UCS-2LE encoded asf tag

Rich Felker dalias at aerifal.cx
Thu Aug 24 19:41:08 CEST 2006


On Thu, Aug 24, 2006 at 06:47:05PM +0200, Reimar Döffinger wrote:
> Hello,
> On Thu, Aug 24, 2006 at 08:57:55AM +0800, Zuxy Meng wrote:
> > 2006/8/23, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > >IMHO the charset that MPlayer uses internally is supposed to always be
> > >UTF-8, and I do not like adding the iconv dependency.
> > 
> > Isn't the internal encoding defined as MSG_CHARSET? Then mp_msg()
> > converts from MSG_CHARSET to mp_msg_charset (using iconv) and print
> > messages out to stdout/stderr.
> 
> Well, yes. But I (and AFAICT others) consider the case MSG_CHARSET !=
> UTF8 a legacy setup (the only reason for having this is lack of
> iconv/libiconv) and not worth adding bloated/ugly or complicated code.

Agree totally. Due to the wide range of file formats supported,
MPlayer's internal text handling needs to be able to handle all
characters, not just a local subset. UTF-8 is the only sane choice for
message charset. If we really need to support systems without iconv,
we could make a fake iconv that first converts UTF-8 to UTF-32 then
uses the ISO C multibyte functions to convert to the local encoding
for display...

Rich




More information about the MPlayer-dev-eng mailing list