[MPlayer-dev-eng] [PATCH] mention libdvdnav in 'configure --help' and switch autodetection on

Diego Biurrun diego at biurrun.de
Wed Aug 9 11:31:03 CEST 2006


On Fri, Aug 04, 2006 at 05:18:21PM -0400, The Wanderer wrote:
> Diego Biurrun wrote:
> 
> >On Fri, Aug 04, 2006 at 08:28:41AM -0400, The Wanderer wrote:
> >
> >I commented out all the dvdnav stuff ages ago because it was not
> >working.  Nico reenabled it in preparation for the dvdnav patch from
> >Attila Otvos.  I'm not quite sure in what state it is right now, so
> >I'm somewhat hesitant to add them back.
> 
> Acknowledged. Does this, in fact, mean that the options should not be
> documented in --help? Or should they be there, but default to 'disabled'?

Oh, that's a difficult one.  In an ideal world we will have support for
dvdnav in the not-so-distant future...

> >There is not much intentional about it.  The help output should be in
> >a logical order.
> 
> What would qualify as logical, then, aside from the kneejerk
> "alphabetical order within categories"? I could certainly take a stab at
> it, but I've long since discovered that my ideas of what makes sense
> don't necessarily agree with those of other people.

output drivers together, codecs together, etc

Apart from that alphabetical order mostly makes sense.

> >>B) There are a number of inconsistencies in the help output - most
> >>obviously, differences in capitalization of option descriptions
> >>(compare the '--enable-live' and '--enable-menu' options for an
> >>example). There are also some odd indentation issues, and a few
> >>possible 'grammar' errors (mostly miscapitalization of names).
> >>Fixing this would be an entirely cosmetic change, affecting most of
> >>that section of the script, but I think it might be worthwhile in
> >>principle.
> >
> >Go right ahead.
> 
> Since this can be done independently of any of the changes above, and
> would conflict with any of them, I think I'll do either this or the much
> simpler 'mtrr' one first. Expect a SVN-account mail from me in the next
> day or so, once I finally settle on a (sufficiently non-guessable)
> password I'm happy with.

Don't bother too much, so far 90% of passwords were too simple and set to
more secure values by myself.

Diego



More information about the MPlayer-dev-eng mailing list