[MPlayer-dev-eng] [PATCH] mention libdvdnav in 'configure --help' and switch autodetection on

[Diego Biurrun]

On Fri, Aug 04, 2006 at 05:16:04PM -0400, The Wanderer wrote:
> Nico Sabbi wrote:
> 
> >The Wanderer wrote:
> >
> >>Apparently, even though configure recognizes the '--enable-dvdnav',
> >> '--with-dvdnavdir' and '--with-dvdnav-config' options, they are
> >>not listed in 'configure --help' - and, possibly as a result,
> >>dvdnav support still defaults to "no" with autodetection run if it
> >>is set to "yes". The attached patch corrects both points. If there
> >>was some reason why dvdnav was disabled by default, it should still
> >>be listed as such in the help output; in any case, it appears to
> >>compile just fine for me, though I'm not presently in a position to
> >>test the resulting binary.
> >
> >>echocheck "DVD support (libdvdnav)"
> >>-if test "$_dvdnav" = yes ; then
> >>+if test "$_dvdnav" = auto ; then
> >
> >+if test "$_dvdnav" != no ; then
> 
> Unfortunately, this means that the detection will be run even if
> '--enable-dvdnav' is specified, which disagrees with our preferred
> syntax. Admittedly the detection in question is mostly a matter of
> making sure that the (specified or guessed) dvdnav-config and dvdnavdir
> are correct, but if the --enable option is specified, AIUI this should
> not be done...

Correct, there should be no autodetection when a variable is set to yes.

Diego