[MPlayer-dev-eng] [PATCH] Add support for GNOME screensaver

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Thu Apr 27 21:18:31 CEST 2006


On Thu, Apr 27, 2006 at 05:30:18PM +0200, Piotr Kaczuba wrote:
> Below the forth revision of my patch. I've made the following changes:
> 
> 1. Make HAVE_DBUS_GLIB actually appear in config.h
> 2. Move gnome_screensaver.o rule from config.mak to Makefile
> 3. Run autodetection in configure only if _dbus_glib = auto
> 4. Replace g_print/g_printerr with mp_msg in gnome_screensaver.c

Nice, thanks for taking the time to do so. just a minor correction:

if youre going to use mp_msg then you need to make sure message levels
between MSGL_FATAL-MSGL_STATUS are translatable and not harcoded as
english strings in your code. see help/help_mp-en.h for a glance on how
its currently done.

regards

	Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060427/f5c49f33/attachment.pgp>


More information about the MPlayer-dev-eng mailing list