[MPlayer-dev-eng] [PATCH] win32 gui

[Guillaume Poirier]

Hi,

Erik Lunchpail wrote:
>  
> 
>>I've tested mplayer-gui-rtm-cvs-20060323.7z, and found a bug: when
>>activating "always on top" from the keys (key 'T'), it always print
>>'Stay on top: disabled', and doesn't stay on top at all. CVS version
>>doesn't suffer from that bug.
> 
> 
> That's quite an old version, the gui has had many major bugfixes since
> then.

Ok, my bad.


> The lastest i've sent to Gianluigi and as well, on the list is
> quite stable. I checked it out, that seems to be related to using WinID
> (which is what the sub window uses) and i'm not sure if that's
> intentional or not. Nonetheless, disabling the use of the sub window
> (in preferences) works around the problem for now. It could very well
> be an issue within vo_directx.c related to the use of WinID. The latest
> is on my homepage (http://vayne.fdns.net) but it includes Otvos
> Atilla's dvdnav patch and the gui dvdnav patch, and is therefore
> experimental.

Ok, I'll test your version. I usually don't watch DVDs with MPlayer (I
prefer my comfy chair in front of the DVD player on the living room),
so it hopefully shouldn't matter.


> Furthermore, using -geometry when using WinID won't work either (and
> should probably be disabled). The vo layer is placing the output in one
> place (with geometry) and the external prog may be placing the window
> in another place (SetWindowPos(), SetWindowPlacement()).
> 
> The option to disable the sub window as WinID I believe I added after
> 20060323, so check a binary on my homepage if you can. It should always
> have the ability to fall back to a standard mplayer vo.

Okay, will do.

Anyway, so far, so good, even though there is this problem and
probably others, it doesn't crash, which is really nice when testing
experimental stuff.

Keep up the good work,

Guillaume