[MPlayer-dev-eng] [PATCH] GUI: add cheap subtitle switching for non-DVD

Guillaume POIRIER poirierg at gmail.com
Sat Apr 22 15:24:58 CEST 2006


Hi,

On 4/22/06, Stanislav Maslovski <stanislav.maslovski at gmail.com> wrote:
> On Sun, Apr 16, 2006 at 06:58:46PM +0200, Guillaume POIRIER wrote:
> > > > This patch adds "cheap" subtitle switching for non-DVD playouts
> > > > (for ex. OGG or MKV). This patch should apply okay even without my
> > > > previos patches that correct audio/video switching in gtk/menu.c
> > >
> > > Seems good enough for me. I'll apply it unless someone disagrees.
> >
> > Applied. Thanks!
>
> Well, there was a better and simpler way of doing things:
> using mp_property_do(). I have corrected the code to use this.
> It makes possible switching of the subtitles without restarting
> the play and works correctly for external subs too.
> The patch is attached.

Much, much better. Applied, thanks!


> Similar change should be done to audio/video switching (will try to do next).

Good, can't wait!

Guillaume
--
I am disillusioned enough to know that no man's opinion on any subject
is worth a damn unless backed up with enough genuine information to
make him really know what he's talking about.

-- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists)
http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html




More information about the MPlayer-dev-eng mailing list