[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Apr 19 21:38:21 CEST 2006


On Wed, 2006-04-19 at 15:59 +0200, Reimar Döffinger wrote:
> Code should be documentated as described in
> DOCS/tech/code-documentation.txt, i.e. doxygen comments at least for
> every global function/variable, and IMHO also for local (i.e. "static"
> functions.

That file claims there should be comments for "every function, no matter
whether it is globally or just locally used". No code in MPlayer really
follows that, nor should it IMO (commenting obvious things is just
clutter, more likely to cause confusion as the code in question changes
than to help).

> 2) how difficult would it be to make a vo support this? I think for this

I think working on this would be better done after the current version
of the patch has been applied first.




More information about the MPlayer-dev-eng mailing list