[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Uoti Urpala]

On Wed, 2006-04-05 at 23:57 +0400, Evgeniy Stepanov wrote:
> Here is an improved patch.

The end time for subtitles is when they should disappear already, so the
"(ass_current_timecode <= (event->Start + event->Duration))" test in
render_frame should use "<" instead of "<=".

The fonts seem too small, I get a better match with some screenshots
from Windows by setting the font_size_coeff value to .8 instead of .6
(though I'd like to know why a multiplier is needed at all).

There is no code path where it wouldn't complain about missing
PlayResX/PlayResY (if both are set then it incorrectly says PlayResX is
missing).

It seems the FT_Set_Char_Size calls do not take PlayResX/PlayResY into
account (the first of them calculates a "size" variable using PlayResX
but then doesn't do anything with the result). However the subtitles
I've tested have had PlayRes equal to the video dimensions so that is
not the cause of the too small looking font sizes.