[MPlayer-dev-eng] [PATCH] switch audio delay keys

Diego Biurrun diego at biurrun.de
Sat Apr 15 17:14:03 CEST 2006


On Sat, Apr 15, 2006 at 06:06:15PM +0300, Ivan Kalvachev wrote:
> 2006/4/15, Diego Biurrun <diego at biurrun.de>:
> > On Tue, Apr 04, 2006 at 09:05:31AM +0200, Diego Biurrun wrote:
> > > After Uoti Urpala's mail I've stumbled over the fact that the keys that
> > > set audio delay are backwards from what is documented...
> > >
> > > man page:
> > >
> > >   + and -
> > >     Adjust audio delay by +/- 0.1 seconds.
> > >
> > > code:
> > >
> > >   { { '-', 0 }, "audio_delay 0.100" },
> > >   { { '+', 0 }, "audio_delay -0.100" },
> > >
> > > So I suggest the attached patch to bring this in line with the
> > > documentation.  Increasing the delay with '+' and decreasing it with '-'
> > > is the only sane way...
> >
> > Applied.
> 
> Did you ever make the effort to read the discusion before going ahead
> and commit that?

Yes I did.  The consensus was that the behavior was extremely illogical.
Further changes to the code may be in order, but this is a first step.

Diego




More information about the MPlayer-dev-eng mailing list