[MPlayer-dev-eng] [PATCH] fix compilation on intel mac

[Nicolas Plourde]

On 4-Apr-06, at 5:45 PM, Rich Felker wrote:

> On Wed, Mar 22, 2006 at 07:58:33AM -0500, Nicolas Plourde wrote:
>> +#ifdef MACOSX
>> +    ".align 4\n\t"
>> +#elif
>>  	".balign 16\n\t"
>> +#endif
>>  	"1:				\n\t"
>>  	"movaps (%0, %%"REG_S"), %%xmm0	\n\t"
>>  	"movaps 16(%0, %%"REG_S"), %%xmm1\n\t"
>> @@ -714,7 +718,11 @@
>>  	"movlps %1, %%xmm7		\n\t"
>>  	"shufps $0x00, %%xmm7, %%xmm7	\n\t"
>>  	"mov $-1024, %%"REG_S"		\n\t"
>> +#ifdef MACOSX
>> +    ".align 4\n\t"
>> +#elif
>>  	".balign 16\n\t"
>> +#endif
>
> Repeating this nonsense over and over is absolutely incorrect. I'm
> slightly against the patch in general, but if you want to do something
> like this, you must:
>
> 1. Test in configure to see if the assembler supports .balign.
> 2. #define a macro ALIGN_16_ASM to ".align 4" or ".balign 16"
>    depending on the results of the test from 1.
> 3. Replace all occurrances of ".balign 16" with ALIGN_16_ASM.
>
> Both OS-specific ifdefs (rather than feature-specific ones) and
> repeated redundant ifdefs are disgusting and unacceptable from a code
> maintainence standpoint.
>

There is no ifdef in the patch i sent this morning. I use #define  
ASMALIGN16. Dont take into account the ffmpeg patch its not inteded  
to be applied has is. Im attaching the mplayer specific patch again  
for review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: intel_osx.diff
Type: application/octet-stream
Size: 30675 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060404/b085f1c9/attachment.obj>
-------------- next part --------------

====
Nicolas Plourde <nicolas.plourde at gmail.com>