[MPlayer-dev-eng] [PATCH] cross-compile: directfb version detection

[Diego Biurrun]

On Mon, Oct 10, 2005 at 12:01:53AM +0200, Aurelien Jacobs wrote:
> This is the third cross-compilation patch.
> It changes the way the directfb version is detected so that it don't
> need to run the generated binary.

This one looks wrong.

> @@ -3459,7 +3459,14 @@
>  }
>  EOF
>    if cc_check $_inc_directfb -ldirectfb && "$TMPO" >> "$TMPLOG" ; then
> -    _directfb_version=`"$TMPO"`
> +   cat > $TMPC <<EOF
> +#include <directfb_version.h>
> +int
> +dfb_ver = DIRECTFB_MAJOR_VERSION DIRECTFB_MINOR_VERSION DIRECTFB_MICRO_VERSION
> +;
> +EOF
> +   if $_cc -E $TMPC $_inc_directfb > "$TMPO"; then
> +    _directfb_version=`sed -n 's/^dfb_ver[^1-9]*\(.*\)/\1/p' "$TMPO" | tr -d '() '`
>      _def_directfb_version="#define DIRECTFBVERSION $_directfb_version"
>      if test "$_directfb_version" -ge 913; then
>  	_res_comment="$_directfb_version"

There is a test for this very thing above, what about it?

> @@ -3468,9 +3475,13 @@
>  	_directfb=no
>  	_res_comment="version >=0.9.13 required"
>      fi
> -  else
> +   else

cosmetics

Patch rejected.

Diego