[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

[Alexander Strasser]

Ivan Kalvachev wrote:
> 2005/11/27, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>:
> -	 if (test_mix_index = strchr(mix_name, ',')){
> +	 if ((test_mix_index = strchr(mix_name, ','))){
> 
> this looks a little pointless. maybe there is something missing?

    GCC issues the following warning when compiling with -Wall for
  example:

  "Warning: suggest parentheses around assignment used as truth value"

    AFAIK it is done for making sure the programmer intended to do
  an assignment and dit not accidently write `=' instead of `=='.

    I don't know if i like it that much; at least it doesn't hurt
  (too much, IMHO it hurts readability a little) and similar changes
  were applied before. So i wouldn't object now.

  Alex (beastd)