[MPlayer-dev-eng] [PATCH] clean up some muxer messages

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Sat Nov 26 00:10:49 CET 2005


On Fri, Nov 25, 2005 at 11:28:56PM +0100, Diego Biurrun wrote:
> On Fri, Nov 25, 2005 at 12:33:05PM -0800, Corey Hickey wrote:
> > > As promised, here is a patch that converts the hardcoded strings I added
> > > to the muxer frame buffer into MSGTR_ messages. I also converted the AVI
> > > header-writing and index-writing messages into more accurate
> > > muxer-specific versions. In detail:
> > >
> > > * Converted new strings in muxer_write_chunk to MSGTR_*
> > > * Moved MSGTR_WritingAVIHeader from mencoder.c section to muxer section
> > > * Added MSGTR_WritingMPEGHeader and MSGTR_WritingLAVFHeader
> > > * Put muxer-specific header-writing messages in individual muxers
> > > * Changed MSGTR_WritingAVIIndex to MSGTR_WritingAVITrailer
> > > * Added MSGTR_WritingMPEGTrailer and MSGTR_WritingLAVFTrailer
> > > * Put muxer-specific trailer-writing messages in individual muxers
> > > * Removed MSGTR_FixupAVIHeader (the mp_msg() in each muxer will suffice)
> > > * #include "help_mp.h" where necessary
> > 
> > Diego? This is the separate messages patch you requested a while ago that
> > corresponds to the muxer frame buffer patch I wrote.
> 
> This is Reynaldo's territory now :)  Or whoever committed the first part
> of your patch.  If none of them react within the week, ping me again,
> i'll try to review this patch then.
> 

I will review and apply if appropiated, thanks for taking the
time Corey.

Best regards

   Reynaldo
   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051125/8cba8c06/attachment.pgp>


More information about the MPlayer-dev-eng mailing list