[MPlayer-dev-eng] [PATCH] misc small fixes (mostly gcc warnings)

Diego Biurrun diego at biurrun.de
Thu Nov 10 02:27:09 CET 2005


On Thu, Nov 10, 2005 at 01:34:33AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> Yes, it's this time of the year again.

:)

> 12. muxer_mpeg.c:2315: warning: implicit declaration of function 'mp_get_mp3_header'
>     muxer_mpeg.c:2339: warning: implicit declaration of function 'a52_syncinfo'
> 
> #include "mp3_hdr.h"
> #include "../liba52/a52.h"

Please don't add (more) .. #includes.  Since -I.. is in the CFLAGS this
is unnecessary.

> 21. sysdep/pci_linux.c:93: warning: implicit declaration of function 'iopl'
> 
> Gabu said including <sys/perm.h> broke compilation on his libc5 system, but...

Let's try not to break libc5 systems unnecessarily...

Diego




More information about the MPlayer-dev-eng mailing list