[MPlayer-dev-eng] [PATCH] Coring filter

[Guillaume POIRIER]

Hi,

On 6/27/05, Jan Paul Schmidt <jps at fundament.org> wrote:
> 
> Am 27.06.2005 um 10:43 schrieb Diego Biurrun:
> 
> > On Sun, Jun 26, 2005 at 11:28:12PM +0200, Jan Paul Schmidt wrote:
> >>
> >> this is my type of a coring filter for MPlayer/MEncoder. See
> >> attachments. vf_coring.c is the new filter file and vf_coring.diff the
> >> patches to integrate it into the source tree.
> >
> > In the man page you need to start sentences on a new line
> 
> What do you mean by that? It looks like other filter entries here?

I'm sure it's not the case. Here, you need to turn your description from this:
+.IPs <threshold>

+The threshold for the coring. The range can be between 0 to 255. 

+Default is 0 (no coring).

+.IPs <black>

+If the black parameter is set to 1, then the threshold value is used as the

+value for the luminance. This can avoid hard edges and abrupt color changes

+but results in a more gray like black.

+.RE

into this:

+.IPs <0\-255>

+The threshold for the coring (default: 0 no coring).
+.IPs <black>

+If the black parameter is set to 1, then the threshold value is used as the

+value for the luminance.
+This can avoid hard edges and abrupt color changes but results in a
+more gray like black.

+.RE

See what I mean? :-)


> > Apart from that you should describe the filter's purpose and
> > shortcomings in more detail.
> 
> Good point.
> 
> > The discussion with Rich shows that this is necessary.
> 
> Does it? Rich understood the filter, I think.

He probably did, but Rich is not the only person who may be interested
in using your filter, therefore it's a good idea to document things a
bit more. :o)


Guillaume
-- 
A woman isn't complete without a man.
But where do you find a man - a real man - these
days?
  -- Lauren Bacall
My answer: Only at #mplayerdev on the freenode IRC network.