[MPlayer-dev-eng] [PATCH] lirc repeat patch

[Guillaume POIRIER]

Hi,

On 6/25/05, Lev A. Melnikovsky <leva at despammed.com> wrote:
> Hi,
> 
>     On Tue, 21 Jun 2005 at 10:25pm, Reimar Dцffinger wrote:
> 
> >> In reality it works as follows: the lirc library does sends n-1 empty
> >> events then 1 informative, then again...
> > Why on earth does it send "empty" events the instead of just swallowing
> > them??
> No idea, it can, so it does...
> Probably I'm not the right person to be asked about it.
> 
> > Though that kind of functionality might be more appropriate in input.c,
> > around line 701. I looks like something like that is already
> > half-implemented??
> > I don't know, but maybe you can introduce an MP_INPUT_RETRY return
> > value (that is sent for such an empty event) and do a continue;
> > in that switch statement in input.c. Don't know if you can detect those
> > "empty" events easily though.
> > But that would be a solution others could maybe profit from as well...
> Well, I couldn't imagine that somebody may need such a hook, but if you
> think so, here it goes. The patch adds MP_INPUT_RETRY as suggested.
> Needless to say - it works here. I have also added "default:" branch to
> the switch construct, just in case.

Yummy! That's a lot clearer looking. What do you think about it Reimar?

Regards,

Guillaume
-- 
A woman isn't complete without a man.
But where do you find a man - a real man - these
days?
  -- Lauren Bacall
My answer: Only at #mplayerdev on the freenode IRC network.