[MPlayer-dev-eng] patch for stereoscopic support

Gabriel A. v. Winckler winckler at tpn.usp.br
Fri Jun 17 00:09:00 CEST 2005


On Thu, 2005-06-16 at 10:05 +0200, Reimar Döffinger wrote:

> > +			glDrawBuffer(GL_BACK_LEFT);
> > +			glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
> 
> You shouldn't clear it here but instead directly after doing the
> flipping, for performance reasons.

You are absolutely right, fixed (I hope it's in the right place now)

> > +	  if (quadbuffer_stereo)
> > +		  vo_draw_text(image_width/2.0,image_height,draw_alpha_fnc);
> 
> Why using 2.0 (float) instead of just 2?

Habit, bad habit. Fixed

> I guess this should use the new suboption parser.
> 

I has using the 1.0pre6 version. Fixed


So, think about this patch.

Thanks,

Winckler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-stereo-v2.patch
Type: text/x-patch
Size: 6797 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050616/1acedd8f/attachment.bin>


More information about the MPlayer-dev-eng mailing list