[MPlayer-dev-eng] [PATCH] Show OSD status when cicling with 'o'

Paul TT paultt at hackerjournal.it
Thu Jun 16 11:07:30 CEST 2005


On Tue, 14 Jun 2005 07:35:06 -0400
kiriuja <mplayer-patches at en-directo.net> wrote:

> On Tue 14 Jun 2005 04:05, Paul TT wrote:
.....
> > > Well, first of course if you give an explicit argument you are saying
> > > ......
> > > So if the patch says "if (slave_mode == 0)" instead of "if (v < 0)"
> > > that will be fine with me as well. If a frontend wants to display the
> > > message, it can always say osd_show_text "OSD: disabled" a second or
> > > two before "osd 0".
> > 
> > it shows up only when switching pressing 'o' r-dev-eng
> 
> Pressing 'o' sends an "osd" command to the input layer. When a frontend
> sends and "osd 0" or "osd 1", the same code is executed. So the (v < 0)
> check is needed if you want the message to only show when the 'o' key
> is pressed. This is my only objection to your patch.

in this situation i'm in slave mode, right. so maybe is more correct to test slave_mode?
or am i wrong????




More information about the MPlayer-dev-eng mailing list