[MPlayer-dev-eng] [PATCH] Clean up ao_macosx by removing AudioConverter

[Alexander Strange]

On Jun 10, 2005, at 3:45 PM, Chris Roccati wrote:
>> This patch removes the use of AudioConverters from the macosx  
>> audio output; AUHAL can do all conversion internally and more  
>> efficiently than trying to do it before the AudioOutputUnit ever  
>> sees any data.
>>
>
> It works fine (although I see no real difference in performance).

It's mostly just to make it neater, but doing it this way  
theoretically works better on audio outs that are capable of multiple  
sampling rates.

> I didn't actually understand Apple's documentation about the  
> AudioUnits.

Neither did I; I learned them by reimplementing the Apple sample  
PlayAudioFile from scratch.

> I suggest you to check for the various "cosmetic" edits and provide  
> a "corrected" version for committal.

I'll do another check through it, but I think that using 'cvs diff - 
b' ("ignore changes in the amount of white space") avoids most of them.


>> There are two potential issues left in ao_macosx that I can see:
>> * Ever since ao_macosx was changed to use AUHAL, I've been having  
>> a problem where the first frame of a movie shows up extremely late  
>> and mplayer skips a lot more frames than normal for a while before  
>> settling down. I think this patch has changed it a little, but  
>> I'll have to look into it more.
>>
>
> This appears to happen because of a massive audio buffer underrun  
> when the movie starts, which I can't seem to track

That's as far as my theory's gotten, but I don't see why it didn't  
happen in the old version...