[MPlayer-dev-eng] [PATCH] MinGW compile fix, header order policy suggestion

[Joey Parrish]

On Thu, Jun 02, 2005 at 01:19:31PM -0400, Rich Felker wrote:
> > from us.)  Renaming to MP_STREAM_SEEK is a better idea, IMHO, because
> > then we aren't fighting a namespace war against an OS who cares nothing
> > for open source devs.
> 
> And should we obfuscate every single symbol in MPlayer like this? NO!
> There is no war unless we use broken mingw headers. Just remove them
> and prototype the 5 or 10 functions you need manually.

It's not obfuscation!  It's a very simple renaming of 1 symbol.
And since it's only for use internally in MPlayer, we can call it
whatever we like.  We don't have to keep STREAM_SEEK for compatibility
with some other app.  Why is this such a big deal?

> >  We _could_ play a game of adding countless
> > #define/#undef around each MingW include, but what's the point?  It'll
> > just happen again later, and then we'll have a huge unmanagable mess
> > around every file that needs a windows header on MingW.  Any fix other
> > than renaming to MP_STREAM_SEEK (or something similar) simply does not
> > scale.  I think it would be foolish to wrap the windows headers.
> 
> Well it will not be renamed. We will not have our symbol names
> dictated by windows crap. MPlayer policy has always been to work
> around broken systems individually, not change our code to suit them.

Saying "this is how we will do it" does not make it a good solution.

--Joey

-- 
"I can read it better than you can read it with your eyes closed." --Gu