[MPlayer-dev-eng] [PATCH] CQMs in x264

[Diego Biurrun]

On Tue, Jul 26, 2005 at 02:34:23PM +0100, Robert Swain wrote:
> On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Jul 26, 2005 at 12:20:56PM +0100, Robert Swain wrote:
> > > On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> > > > something along the lines of
> > > >
> > > > cqm[=<flat | jvt | <filename> >]
> > > >
> > > > Look around the man page for examples.
> > >
> > > I've used the xvid quant_type style and gone for cqm=<jvt|flat|<filename>>.
> > 
> > The [] are there for a reason most of the time, btw.  Does specifying
> > just cqm without parameters work?  Then add [].
> 
> Were you expecting me to answer 'No'? I assume you were. So [] means
> that the parameter is mandatory?

No, optional.

> > What is the whole paragraph after the option descriptions about?  I
> > cannot figure out the connection to the cqm option.  You start talking
> > about lists, what lists?
> 
> I added another method of input on request. In the x264 CLI interface
> you can specify comma separated lists of values for the matrices. The
> paragraph just explains that the following cqm* x264 options are for
> the corresponding comma separated lists. The reason it isn't related
> to the cqm option is because this was the neatest and most
> comprehensible way to implement it in my opinion. Should I remove the
> paragraph or move it to be below the cqm list options?

I still don't quite get what this is all about, but you cannot leave it
as part of the cqm option descriptions.  If it is a separate thing you
need to put it somewhere separate.

Diego