[MPlayer-dev-eng] Re: [PATCH] OSD: audio switching visualization::3rd try

[Paul TT]

On Thu, 1 Dec 2005 14:40:35 +0100
Alban Bedel <albeu at free.fr> wrote:

> On Thu, 1 Dec 2005 02:56:25 +0100
> Paul TT <paultt at hackerjournal.it> wrote:
> 
> > here i am again
> > updated the code to apply to new changes in mplayer.c...
> > the stuff about changing audio it's little messy as the one about
> > switching subtitles...
> > when that will be ordered, i can give my hand to reorder the audio
part
> > too...
> 
> That's a bad idea imho. Why not doing it right from the start ?
> Their should be a single interface (usging ctrl call) to get the audio
> and sub languages (in text form) from the demuxer or failing that from
the
> stream. I see no reasons to polute mplayer.c with even more
demuxer/stream
> specific code.

what can i say? you're right. if this patch is applied i can, in a week
or two, reorganize the code of mplayer+demuxers, to do just what you
say.
i already thought about it, i would write only one function to get audio
or video ids and text atrtibute, passing it the stream type i want
information from, so for example:

get_id_from_lang(char*lang, int ID_TYPE);
get_lang_from_id(int id, ID_TYPE);

and implement these in the interested demuxers... (fictional functions
names and declarations, just to make my explanation clearer, didn't yet
thought about the names indeed)

i can do that , but only after apllying of the patch (messing) above, i
don't really have time to waste just to run after modifications in the
code to adapt this patch day by day...

what do you (not only you, also others ;-)) think about it?