[MPlayer-dev-eng] [PATCH] forceable software volume control

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Nov 12 12:44:17 CET 2004


Hi,
> > RD>This just does not work as easy as that in the digital case. Amplifying
> > RD>2x means you need one extra bit, for 8x amplification you need 3 extra
> > RD>bits. So without changing the format (hard to do as often both source
> > RD>and soundcard want 16 bit), this will only work when whoever created the
> > RD>file wasted at least 3 bits out of 16 by not adjusting the volume
> > RD>correctly. I am not convinced that adjusting to such crap is a good
> > RD>idea.
> > 
> > With -af volume module I had to use values as high as 15 sometimes to
> > get to the average volume level on some content. According to your
> > calculations, I should have heard very low-quality sound... but that
> > wasn't the case. Or do I miss something?
> 
> no, he misses somethoing: the fact that most dvds only use 10-12 of the
> 16 bits of dynamic range.

I could now say that you miss the point that I have no DVDs ;-)
But anyway, this way only very little code needs to be changed and it
works perfectly for me and is also consistent to how (at least my)
hardware mixer behaves.
Anyone who wants it different can change it, this is free software after
all and also I'm certainly not the only one with CVS access.
So in short: I will apply this version on Sunday unless you don't want
me to do that. In that case write, send and apply your own patch.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list