[MPlayer-dev-eng] [PATCH] HE-AAC support

Loren Merritt lorenm at u.washington.edu
Thu Mar 25 02:07:14 CET 2004


faad's audio_out_minsize didn't take into account the internal upsampling
of HE-AAC, resulting in a buffer overflow in decode_audio
(libmpcodecs/ad_faad.c:218).
I allowed an additional factor of 2 for decoding to 32-bit int.

--Loren Merritt
-------------- next part --------------
--- libmpcodecs/ad_faad.c~	2003-09-21 10:05:51.000000000 -0700
+++ libmpcodecs/ad_faad.c	2004-03-24 16:18:53.000000000 -0800
@@ -42,7 +42,7 @@
 
 static int preinit(sh_audio_t *sh)
 {
-  sh->audio_out_minsize=2048*FAAD_MAX_CHANNELS;
+  sh->audio_out_minsize=8192*FAAD_MAX_CHANNELS;
   sh->audio_in_minsize=FAAD_BUFFLEN;
   return 1;
 }


More information about the MPlayer-dev-eng mailing list