[MPlayer-dev-eng] [PATCH] exit_player

Joey Parrish joey at nicewarrior.org
Mon Aug 30 20:41:19 CEST 2004


On Mon, Aug 30, 2004 at 08:13:02PM +0200, Reimar Döffinger wrote:
> >-  if(sig_count==5 || (inited_flags==0 && sig_count>1)) exit(1);
> >+  if(sig_count==5 || (inited_flags==0 && sig_count>1)) exit_player(NULL);

> I'm not sure if that's correct... As far as I understand it, this if 
> executed when a signal was caused by the signal handling code. So if the 
> exit_player function causes a segfault wouldn't this get us stuck in an 
> endless loop?
> Maybe somebody with actual linux programming experience can comment ;-)

It just makes calls to mp_msg and such, but you are probably correct.
There is not much enthusiasm for this patch, so I wouldn't worry about
it.  If it evers get resubmitted or seriously considered, then that
change will be taken out.

--Joey

-- 
"There's no blood in your brain?  You're one of the lucky ones." --Chad




More information about the MPlayer-dev-eng mailing list