[MPlayer-dev-eng] [PATCH] fixing rgb24toyv12

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Aug 10 15:31:57 CEST 2004


Hi,
the attached patch should fix rg24toyv12. The problem is described in 
the thread starting at 
http://mplayerhq.hu/pipermail/mplayer-users/2004-August/047515.html.
The line changing width to chromaWidth in the MMX code would have been 
enough to fix that, but I found some more problems:
1) looks like the C version was supposed to be a fallback for uneven 
height, but it would not work (correctly) in that case either because of 
the  code around line 2332. I fixed by making it ignore the borders 
(yes, I know that's bad, but I don't think really fixing it is worth the 
effort).
2) I made the C version use all four pixels for chroma calculation, just 
like the MMX version (can be switched off by defining FAST_BGR2YV12)

Greetings,
Reimar Döffinger
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rgbtoyv12_fix.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040810/b0cedddb/attachment.txt>


More information about the MPlayer-dev-eng mailing list