[MPlayer-dev-eng] [PATCH][RESEND] XV page flipping sync

Alexander Strasser eclipse7 at gmx.net
Sun Aug 1 14:34:12 CEST 2004


On Sat, Jul 31, 2004 at 05:36:32PM +0900, Attila Kinali wrote:
> On Wed, Jun 23, 2004 at 09:23:11PM +0300, Ivan Kalvachev wrote:
> > Joey Parrish said:
> > Okay, the first patch removes XFlush whenever it's redundant with XSync
> > calls.  The second patch removes all XFlush everywhere.  I know little of X,
> > but I feel like the first one is probably safe and the second one is
> > probably wrong.  I leave it to somebody else to apply.
> > >
> > > Patches actually attached this time.  :)
> > >
> > > --Joey
> > 
> > Somehow I don't like both patches.
> > I agree it is pointless to have BOTH XFlush and XSync, but I'm not sure that
> > XFlush is always the one that should be removed.
> 
> I agree with iive here. The first patch which only removes
> XFlush before XSync is ok and can be applied, but the second 
> needs more checking.
> 
> beastd, could you do it or shall i add it to my to-do list ?
I can add it to my todo list, too. You decide :)
About the first patch I also think that it is save and should
be applied. Or does someone have doubts? According to what I
know and read a call to XSync() does the same as a call to
XFlush() with the difference that it waits until the Xserver
actually processed the pending requests.

  Alex (beastd)




More information about the MPlayer-dev-eng mailing list