[MPlayer-dev-eng] Re: [PATCH] Subtitles formatting

D Richard Felker III dalias at aerifal.cx
Mon Sep 1 15:43:16 CEST 2003


On Mon, Sep 01, 2003 at 09:50:54AM +0200, Salvatore Falco wrote:
> > Date: Sun, 31 Aug 2003 00:59:45 -0400
> > From: D Richard Felker III <dalias at aerifal.cx>
> > To: mplayer-dev-eng at mplayerhq.hu
> > > And it works very nicely, except when it sig11's. Please see the
> > > attached file, figure out why it sig11's, and submit a fixed patch.
> > > BTW, it would probably be nice if you could get by with less cosmetic
> > > changes (reindention, spacing, etc.), but since you seem to have
> > > largely rewritten the relevant portion of the code it's ok imo. Just
> > > try to keep cosmetics minimal in the future.
> > 
> > Any progress? Please don't be discouraged by the bug I found -- once
> > it's fixed this patch should be great and I'll apply it right away.
> > Let me know if you don't have any time to work on it and I'll see
> > about fixing it myself.
> > 
> > Rich
> 
> 
> 	The problem is that during weekends I am unplugged from the net.
> As regards the sig11... the subtitle file you provided does not sig11 to
> me; plus, if it does not appear is because you have a blank line between
> the time line and the text line, and thus the subtitle function for
> subviewer skips it.

It's not a blank line (unless it got messed up in the mail) but rather
a line with a single space on it. If it did get messed up, try
putting the space back and see if it crashes then.

Rich



More information about the MPlayer-dev-eng mailing list