[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Arpi]

Hi,

>  > huh?
>  > so vf_eq code is copypasted into vf_eq2? its a total nonsence then.
> 
> I had a quick look at the code, but I really cannot judge.  Somebody
> more knowledgeable should enlighten us on the subject.

ok, i've compared them.
the mmx code from vf_eq is really copied to vf_eq2, under the name
affine_1d_MMX().
the C version isn't copyed, as LUT is faster than pure C multiply.
(btw the vf_eq seems to handle negative contrast/brightness, while
i'm not sure if vf_eq2 handles it correctly in LUT mode!!?)

so vf_eq2 seems to be better than vf_eq, so vf_eq could be removed.
(i was not aware of vf_eq's mmx merge into vf_eq2)

> 
>  > > You also said that vf_eq was obsolete and should be
>  > > superseded by vf_eq2, so I assumed there was no speed penalty.
>  > 
>  > if vf_eq2 contains the vf_eq code, then yes.
>  > but then why dont you simply rm -rf vf_eq ?
> 
> I'm perfectly fine with that.  Apparently there are many things that
> are obsolete and should be removed.  I'll start another thread on the
> subject.

ok.
see DOCS/tech/TODO, it lists a few (like native cinepak, svq1 etc)


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu