[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

Torinthiel torinthiel at wp.pl
Tue Oct 28 15:22:11 CET 2003


Looks like I started the whole thread, so maybe it's time I say
something more ;)
I've noticed (at that time) that eq uses bright:cont and 
eq2 uses gamma:cont:bright:...
It was inconsistent of course, but I wasn't against idea of putting
gamma first. Eq2, after all, is a separate filter, so it can have
different parameters. And it applies to me that gamma is the most often
used parameter, in fact if you don't use gamma then you could not use
this filter. What I had ment was ONLY that brightness and contrast
should be in the same order in both filters. Right now there are in
different order, so if someone wants to remember the params he has to
remember that once brightness is firs, once contrast is and where is
what.
So, to sum up the only change I ment to suggest was (no patch, maybe
later):
eq[=bright:cont]
eq2[=gamma:bright:cont:saturation:rg:gg:bg]
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3075312
   torinthiel(at)wp(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031028/153333dd/attachment.pgp>


More information about the MPlayer-dev-eng mailing list