[MPlayer-dev-eng] [PATCH] vf_bmovl2 - rewrite of vf_bmovl - Extra Tasty Crispy version

Jason Tackaberry tack at auc.ca
Mon Oct 27 19:25:31 CET 2003


On Fri, 2003-10-24 at 16:00, Jonas Jensen wrote:
> A solution to this could be to change bmovl2 to listen on a socket (UNIX
> or INET) instead and allow multiple connections. Or to be able to give
> multiple fifos as arguments. Or a combination of these.
> A socket interface would also allow bi-directional communication so
> bmovl2 could tell the application the width/height/fps of the movie.

This does expand possibilities, but complicates the design.  I think for
most cases that kind of info can be gotten from mplayer's caller via
reading stdout and interacting with slave mode.  On the other hand, I'm
not inherently opposed to using a unix socket for IPC instead of a fifo,
but only if there's really enough of a benefit.

One possibility to get around the multiple connections problem is to use
arbitrary strings as identifiers rather than integers.  As convention,
one could prefix the string with "appname_."  Instead of using an array
to store images, I could just use a linked list with the identifier
being part of the structure.  This would provide flexibility and also
remove the limit on the number of images that you could store.

What do you think?

> But is there anything conceptually wrong with letting the overlay both
> be chainable and survive loadfile? If there is a way for the filter to
> tell which index in the chain it has, could the state not be saved in an

Assuming filters are consistently initialized in the order in which they
are specified (and I can't imagine why they wouldn't be), then yes this
is possible.  It again adds complexity to the code, and I wonder if the
above identifier-as-string idea wouldn't be enough?

> I'd also like support for sending planar YUV images to the filter,
> instead of only packed RGB.

That and PNG too.  It's on my todo list.  Right now I have MMX
optimization on my plate.  Still hacking at that. :)

Cheers,
Jason.

-- 
Jason Tackaberry  ::  tack at auc.ca  :: 705-949-2301 x330 
Academic Computing Support Specialist
Information Technology Services
Algoma University College  ::  www.auc.ca




More information about the MPlayer-dev-eng mailing list