[MPlayer-dev-eng] [PATCH] cygwin mpdvdkit testing

[Diego Biurrun]

OK, it took me some time to get my hands on a box with DVD drive again..

Joey Parrish schrieb:
> I have not in the recent past been able to get cygwin mpdvdkit to work
> properly.  At the moment, I have no cygwin box with a dvd player for
> testing, but for some reason I picked this time to start thinking about
> the problem again.
> 
> If someone can tell me whether their cygwin mpdvdkit is working at the
> moment, that would be great.  (Please test on latest cygwin dll.)
> 
> Try these things without patching:
> mplayer dvd://1 -dvd-device G:
> mplayer dvd://1 -dvd-device /dev/scd0

Fails.

 > mplayer dvd://1 -dvd-device //./G:

Works.

> Try these with patch:
> mplayer dvd://1 -dvd-device D:
> mplayer dvd://1 -dvd-device //./D:

Both work.

> To explain:
> 
> The big things to me are that devices in the form D: can't be statted in
> latest cygwin.  So the form //./d: must be used as device name, but then
> some parts of the code later expect the D: form.  I read something at
> cygwin.com that also lead me to believe that /dev/scd0 would work right,
> but again, I haven't been able to test myself yet.
> 
> This chunk is because I think that [3] is a typo, and [2] is correct.

What's the difference?

> If /dev/scd0 form works on latest cygwin, then making that the default
> device name on CYGWIN is the best fix.  However, I think that working
> support for drive letters would be good.  In that case, the stat part
> of the code should detect the X: syntax and convert it to //./X:, then
> stat that, passing the X: form on, though.  Or, another fix would be to
> make all the X: expecting parts look for //./X: instead and stick to
> that.
> 
> Thoughts?

The //./g: or \\.\g: syntax is braindead as hell, so having g: would be 
nicer indeed.  Sounds good to me if you can accomplish that without any 
gross hacks..

Diego