[MPlayer-dev-eng] Re: [PATCH] theora update #2

[Arpi]

Hi,

> >> just updated ogg demuxer and theora decoder for the changes in the
> >> libtheora API which caused compilation to fail.
> 
> > -// theora_comment tc; + theora_comment tc;
> 
> > if you do such changes, you should also add theora version check in
> > ./configure.  this makes code uncompilable for ppl having older
> > libtheora installed (like me).
> 
> > the best would be do #ifdef VERSION>1234 type thing in the code, so it
> > could work with any version
> 
> sorry, i thought that would not be that important, as theora is still
> very alpha.  it don't expect it to have useful version information yet,

then make it disabled by default...

default-enabled code should not break compilation!
so either add proper detection or just disable by default, so testers
should explicitly enable it at compile time.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu