[MPlayer-dev-eng] [PATCH] EDL 0.6 - DVD chapter support (w/ cvs diff -u)

Diego Biurrun diego at biurrun.de
Fri Jul 25 20:39:35 CEST 2003


On Fri, Jul 25, 2003 at 01:04:29PM -0700, Michael Halcrow wrote:
> On Fri, Jul 25, 2003 at 05:42:09PM +0200, Diego Biurrun wrote:
> > minor nit:
> > 
> > You use (American style) two spaces after a period.  While I like this
> > and also use it in mails etc, most of us are Europeans and accustomed
> > to only one space.  So to conform strictly to our (unwritten) style
> > guide you should also use only one space here.
> 
> I lived in Europe for two years (Italy from '97-'99),

Nice

> and this is yet another nuance that I never picked up.  :-)

Yes, it's probably hard to notice, since everybody understands it..  I
prefer two spaces, readability is better, but customs are customs...

> Do you want me to change this and resubmit the patch, or is the
> current patch acceptable (and I keep this in mind for future patches)?

It's a minor thing, but Gabu has been known to correct two spaces to one and
I sometimes also do it, so if you could redo the patch that would be very
nice.
Thanks

Diego



More information about the MPlayer-dev-eng mailing list