[MPlayer-dev-eng] What is the format of 4bpp? (postproc/yuv2rgb

[Arpi]

Hi,

> > > RG4B (rgb4 byte type)
> >
> > ok.
> found another problem :(
> what about stuff like?
> #define isRGB(x)       (((x)&IMGFMT_RGB_MASK)==IMGFMT_RGB)
> it will need another || x==IMGFMT_RG4B
> we could missuse RGB3 or RGB7, but is it a good idea? the bpp is obviously 
> wrong ...

yes it's good idea, i already thought of that but dropped the idea because
of being messy hack ...
but if we have to choose simplicity+performance vs. nice code, i vote for
the former. so take BGR7

we could also try things like ('BGR'<<8)|(8|128) (use the most sign. bit as
a flag) but it may cause trouble for if(BGR_DEPTH(fmt)<24) type checks.
hmm, maybe not, if we change BGR_DEPTH macro...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino