[MPlayer-dev-eng] [PATCH] GIF support, release quality?

[Arpi]

Hi,

> > it's actually an BGR8->BGRx colorspace converter. If tehre is a palette, it
> > will be used, if no palette then grayscale is assumed.
> > So it bevaes the same way as scale or lavc or other csp converters.
> 
> Yes, except that the format is still BGR8.  lavc and scale can be loaded
why?

> based on requested format or format incompatibilities.  How should
> mpcodecs_config_vo() be notified of the need to load vf_palette?
> vf_palette checks for a palette by checking for the number of planes in
> the mpi it gets, but mpi has not been built when mpcodecs_config_vo() is

wtf?
it has NOTHING with the palette or number of colors.
if the colorspace is BGR8 and the filter chain/vo driver doesn't accept BGR8
then you have to instert vf_palette. easy.

> loaded.  So why not add a flag and make it the job of the decoder to
> signal the rest of mplayer to load that filter?

because if the vo accepts BGR8, then inserting vf_palette is worse than
nothing.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino